Hide ArborX::PairIndexRank #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With APIv2, it is only used in tests. Unless we decide to expose it to a user, but it may be pretty inconvenient, and I don't currently see a way to easily produce such result without callbacks.
aprokop
added
refactoring
dalg24
reviewed
Sep 24, 2024
aprokop
force-pushed
the
hide_pair_index_rank
branch
from
7559673 to
d8f282c
Compare
dalg24
approved these changes
Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With APIv2, it is only used in tests. Unless we decide to expose it to a user, but it may be pretty inconvenient, and I don't currently see a way to easily produce such result without callbacks.